Re: [PATCH v2 05/10] gpu: nova-core: gsp: Add GSP command queue handling

[Alistair Popple]

On 2025-09-30 at 21:58 +1000, Miguel Ojeda <miguel.ojeda.sandonis@xxxxxxxxx> wrote...
> On Tue, Sep 30, 2025 at 1:42 PM Alistair Popple <apopple@xxxxxxxxxx> wrote:
> >
> > Thanks. Is it still expected that `#[allow(clippy::incompatible_msrv)]` is
> > required? Just adding it to `rust_allowed_features` doesn't make the warning go
> > away without the allow, but maybe I'm just doing something wrong...
> 
> The warning is independent of the allowed features, and yeah, it is
> expected that the Clippy may trigger (at this moment when we dance
> with these features), so you can just allow it locally.
> 
> If it is too cumbersome, I may disable it globally.
> 
> I hope that helps!

Thanks! That does help, it's not too cumbersome as we only use it in a few
places. I was just wondering if it was expected or not. A nice future quality
of life improvement might be to automatically disable clippy warnings for
everything in `rust_allowed_features` but I think that's pretty low priority.

> Cheers,
> Miguel