Re: [PATCH v2] watchdog: Add driver for Gunyah Watchdog

[Krzysztof Kozlowski]

On 06/10/2025 16:37, Hrishabh Rajput via B4 Relay wrote:
> +
> +static int __init gunyah_wdt_init(void)
> +{
> +	struct arm_smccc_res res;
> +	struct watchdog_device *wdd;
> +	struct device_node *np;
> +	int ret;
> +
> +	np = of_find_compatible_node(NULL, NULL, "qcom,kpss-wdt");
> +	if (np) {
> +		of_node_put(np);
> +		return -ENODEV;
> +	}
> +
> +	np = of_find_compatible_node(NULL, NULL, "arm,sbsa-gwdt");
> +	if (np) {
> +		of_node_put(np);
> +		return -ENODEV;
> +	}
> +
> +	ret = gunyah_wdt_call(GUNYAH_WDT_STATUS, 0, 0, &res);
> +	if (ret)
> +		return -ENODEV;

No, your hypervisor driver (which you have) should start the module via
adding platform/aux/something devices. Now you are running this on every
machine, which is clearly wrong...

Best regards,
Krzysztof