Re: [PATCH v2] mm: skip folio_activate() for mlocked folios

[Kiryl Shutsemau]

On Tue, Oct 07, 2025 at 12:53:13PM -0700, SeongJae Park wrote:
> On Mon, 6 Oct 2025 13:25:26 +0000 Dmitry Ilvokhin <d@xxxxxxxxxxxx> wrote:
> 
> > __mlock_folio() does not move folio to unevicable LRU, when
> > folio_activate() removes folio from LRU.
> 
> A trivial opinion.  So the user-visible issue is the incorrect meminfo, right?

The user-visible effect is that we unnecessary postpone moving pages to
unevictable LRU that lead to unexpected stats: Mlocked > Unevictable.

> > ---
> > Changes in v2:
> >   - Rephrase commit message: frame it in terms of unevicable LRU, not stat
> >     accounting.
> 
> Yet another trivial and personal opinion.  Adding a link to the previous
> version could be helpful for reviewers like me.

You probably missed recent Linus rant on Link: tags :P

-- 
  Kiryl Shutsemau / Kirill A. Shutemov