Re: [PATCH 4/5] dt-bindings: remoteproc: qcom,sm8550-pas: Document Glymur ADSP

[Sibi Sankar]

On 10/2/2025 6:24 AM, Rob Herring wrote:
> On Thu, Sep 25, 2025 at 12:07:25AM +0530, Sibi Sankar wrote:
> > Document compatible for Qualcomm Glymur SoC ADSP which is fully compatible
> > with SM8750 ADSP. Also with the Linux Host running on EL2, the remoteprocs
> > need to be hypervisor independent, the iommu property is mandatory to
> > ensure proper functionality.
> >
> > Signed-off-by: Sibi Sankar <sibi.sankar@xxxxxxxxxxxxxxxx>
> > ---
> >
> > Dependencies:
> > Peripheral Image Loader support for Qualcomm SoCs running Linux host at EL2:
> > https://patchwork.kernel.org/project/linux-arm-msm/cover/20250921-kvm_rproc_pas-v3-0-458f09647920@xxxxxxxxxxxxxxxx/
> > This patch has a dependency on the iommu binding added in ^^ series.
> >
> >   .../bindings/remoteproc/qcom,sm8550-pas.yaml     | 16 +++++++++++++++-
> >   1 file changed, 15 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml
> > index 2dd479cf4821..cba45ce2865e 100644
> > --- a/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml
> > +++ b/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml
> > @@ -28,7 +28,9 @@ properties:
> >             - qcom,x1e80100-adsp-pas
> >             - qcom,x1e80100-cdsp-pas
> >         - items:
> > -          - const: qcom,sm8750-adsp-pas
> > +          - enum:
> > +              - qcom,glymur-adsp-pas
> > +              - qcom,sm8750-adsp-pas
> >             - const: qcom,sm8550-adsp-pas
> >         - items:
> >             - const: qcom,sm8750-cdsp-pas
> > @@ -95,6 +97,7 @@ allOf:
> >           compatible:
> >             contains:
> >               enum:
> > +              - qcom,glymur-adsp-pas
> >                 - qcom,sm8750-adsp-pas
> >       then:
> >         properties:
> > @@ -185,6 +188,7 @@ allOf:
> >           compatible:
> >             contains:
> >               enum:
> > +              - qcom,glymur-adsp-pas
> >                 - qcom,sm8550-adsp-pas
> >                 - qcom,sm8650-adsp-pas
> >                 - qcom,sm8750-adsp-pas
> > @@ -238,6 +242,16 @@ allOf:
> >               - const: cx
> >               - const: mxc
> >               - const: nsp
> > +  - if:
> > +      properties:
> > +        compatible:
> > +          enum:
> > +            - qcom,glymur-adsp-pas
> > +    then:
> > +      properties:
> > +        iommus:
> > +          minItems: 1
> The min can never be 0, so it is already 1. Drop.

Ack, will drop it.

- Sibi Sankar

> > +          maxItems: 1
> >   
> >   unevaluatedProperties: false
> >   
> > --
> > 2.34.1