Re: [PATCH 1/4] leds: Add Virtual Color LED Group driver

[Krzysztof Kozlowski]

On 13/10/2025 02:24, Jonathan Brophy wrote:
> On FRI, 10 October 2025, Krzysztof Kozlowski wrote:
> 
> 
>>> +	if (!ret) {
>>> +		vled->blink_delay_on = blink_interval;
>>> +		vled->blink_delay_off = blink_interval;
>>> +	}
>>> +
>>> +	phandle_count = fwnode_property_count_u32(child_fwnode, "leds");
>>
>>
>> No, don't mix OF and fwnode.
> 
> Thanks for the guidance I am working my way through the List if fixes and will offer a new patch set when complete.
> 
> Just one question is there a preference to use Device Tree (OF) functions or FWnode functions?
> It is my under standing FWnode is newer and  more universal.

I think fwnode is better, but my comment here was - choose one.

Best regards,
Krzysztof