Re: [PATCH] PCI: sg2042: Fix a reference count issue in sg2042_pcie_remove()

[Chen Wang]

Hi，Manivannan,

I see 6.18-rc1 is released. Could you please pick this fix for 6.18-rcX?

Thanks,

Chen

On 9/30/2025 8:43 AM, Chen Wang wrote:
> On 9/30/2025 2:13 AM, Christophe JAILLET wrote:
> > devm_pm_runtime_enable() is used in the probe, so pm_runtime_disable()
> > should not be called explicitly in the remove function.
> >
> > Fixes: 1c72774df028 ("PCI: sg2042: Add Sophgo SG2042 PCIe driver")
> > Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
>
> LGTM.
>
> Acked-by: Chen Wang <unicorn_wang@xxxxxxxxxxx>
>
> Tested-by: Chen Wang <unicorn_wang@xxxxxxxxxxx> # on Pioneerbox.
>
> Thanks,
>
> Chen
>
> > ---
> > Compile tested only
> > ---
> >   drivers/pci/controller/cadence/pcie-sg2042.c | 3 ---
> >   1 file changed, 3 deletions(-)
> >
> > diff --git a/drivers/pci/controller/cadence/pcie-sg2042.c 
> > b/drivers/pci/controller/cadence/pcie-sg2042.c
> > index a077b28d4894..0c50c74d03ee 100644
> > --- a/drivers/pci/controller/cadence/pcie-sg2042.c
> > +++ b/drivers/pci/controller/cadence/pcie-sg2042.c
> > @@ -74,15 +74,12 @@ static int sg2042_pcie_probe(struct 
> > platform_device *pdev)
> >   static void sg2042_pcie_remove(struct platform_device *pdev)
> >   {
> >       struct cdns_pcie *pcie = platform_get_drvdata(pdev);
> > -    struct device *dev = &pdev->dev;
> >       struct cdns_pcie_rc *rc;
> >         rc = container_of(pcie, struct cdns_pcie_rc, pcie);
> >       cdns_pcie_host_disable(rc);
> >         cdns_pcie_disable_phy(pcie);
> > -
> > -    pm_runtime_disable(dev);
> >   }
> >     static int sg2042_pcie_suspend_noirq(struct device *dev)