Re: [RFC v1 2/2] PCI: j721e: Use inline reset GPIO assignment and drop local variable

From: Siddharth Vadapalli

Date: Mon Oct 13 2025 - 07:22:44 EST


On Mon, 2025-10-13 at 15:47 +0530, Anand Moon wrote:
> Change removes the unnecessary local gpiod variable and assigns the result
> of the devm_gpiod_get_optional() call directly to pcie->reset_gpio.
> This makes the code more concise and readable without changing the
> behavior.
>
> Cc: Siddharth Vadapalli <s-vadapalli@xxxxxx>
> Signed-off-by: Anand Moon <linux.amoon@xxxxxxxxx>

Reviewed-by: Siddharth Vadapalli <s-vadapalli@xxxxxx>

> ---
> drivers/pci/controller/cadence/pci-j721e.c | 13 ++++++-------
> 1 file changed, 6 insertions(+), 7 deletions(-)

[TRIMMED]

I have also tested the series (despite my feedback on the first patch).
Logs:
https://gist.github.com/Siddharth-Vadapalli-at-TI/ca82a16e15a892b3349396be17b37643

Please address the feedback on the first patch.

Regards,
Siddharth.