Re: [PATCH v2] mmc: sdhci: Stop advertising the driver in dmesg
From: Linus Walleij
Date: Mon Oct 13 2025 - 09:16:41 EST
On Thu, Oct 9, 2025 at 8:11 AM Adrian Hunter <adrian.hunter@xxxxxxxxx> wrote:
> On 08/10/2025 01:04, Linus Walleij wrote:
> > As much as we have grown used to seeing this message on
> > every kernel boot, it does not add any technical value.
> >
> > Drop all messages from sdhci_drv_init().
> >
> > We need to keep the module_init/exit() calls to stub
> > functions for the module to work according to
> > <linux/module.h>.
>
> But is that true?
I don't know, I don't have an SDHCI device at hand to test..
The comments say:
/* Each module must use one module_init(). */
And for module_exit():
/* This is only required if you want to be unloadable. */
If it's not true we need to fix the docs as well...
But I discussed it with Ulf in the office last week and he was
frantically testing out dropping it altogether.
Yours,
Linus Walleij