Re: [PATCH v6] sunrpc: allocate a separate bvec array for socket sends
From: Chuck Lever
Date: Mon Oct 13 2025 - 09:42:20 EST
On 10/13/25 9:38 AM, Jeff Layton wrote:
> diff --git a/net/sunrpc/svcsock.c b/net/sunrpc/svcsock.c
> index 0cb9c4d457453b26db29f08985b056c3f8d59447..e979505a21b69267a10d39f9084b557db4c9369c 100644
> --- a/net/sunrpc/svcsock.c
> +++ b/net/sunrpc/svcsock.c
> @@ -68,6 +68,16 @@
>
> #define RPCDBG_FACILITY RPCDBG_SVCXPRT
>
> +/*
> + * For UDP:
> + * 1 for header page
> + * 16 for up to 64kb of payload + 1 in case it's not aligned
> + * 1 for tail page
> + */
> +enum {
> + SUNRPC_MAX_UDP_SENDPAGES = 1 + 16 + 1 + 1
> +};
> +
Remember last week we found the maximum payload size on UDP was actually
32KB. Should you use RPCSVC_MAXPAYLOAD_UDP instead of a raw integer?
Otherwise, LGTM.
--
Chuck Lever