Re: [PATCH] xfs: XFS_ONLINE_SCRUB_STATS should depend on DEBUG_FS

[Darrick J. Wong]

On Mon, Oct 13, 2025 at 10:48:46AM +0200, Geert Uytterhoeven wrote:
> Currently, XFS_ONLINE_SCRUB_STATS selects DEBUG_FS.  However, DEBUG_FS
> is meant for debugging, and people may want to disable it on production
> systems.  Since commit 0ff51a1fd786f47b ("xfs: enable online fsck by
> default in Kconfig")), XFS_ONLINE_SCRUB_STATS is enabled by default,
> forcing DEBUG_FS enabled too.
> 
> Fix this by replacing the selection of DEBUG_FS by a dependency on
> DEBUG_FS, which is what most other options controlling the gathering and
> exposing of statistics do.
> 
> Signed-off-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> ---
>  fs/xfs/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/xfs/Kconfig b/fs/xfs/Kconfig
> index 8930d5254e1da61d..402cf7aad5ca93ab 100644
> --- a/fs/xfs/Kconfig
> +++ b/fs/xfs/Kconfig
> @@ -156,7 +156,7 @@ config XFS_ONLINE_SCRUB_STATS
>  	bool "XFS online metadata check usage data collection"
>  	default y
>  	depends on XFS_ONLINE_SCRUB
> -	select DEBUG_FS
> +	depends on DEBUG_FS

Looks ok to me, though I wonder why there are so many "select DEBUG_FS"
in the kernel?

Reviewed-by: "Darrick J. Wong" <djwong@xxxxxxxxxx>

--D

>  	help
>  	  If you say Y here, the kernel will gather usage data about
>  	  the online metadata check subsystem.  This includes the number
> -- 
> 2.43.0
> 
>