Re: [PATCH 2/2] dmaengine: dw-axi-dmac: add reset control support

[Artem Shimko]

Hi Philipp,

On Mon, Oct 13, 2025 at 6:41 PM Philipp Zabel <p.zabel@xxxxxxxxxxxxxx> wrote:
>
> On Mo, 2025-10-13 at 17:56 +0300, Artem Shimko wrote:
>
> [...]
> > dw_remove() has axi_dma_suspend() function, which is where the reset assertion
> > occurs via reset_control_assert().
>
> It looks to me like dw_remove() is now missing a deassert before
> accessing registers, in case the device is removed while runtime
> suspended.
>
> regards
> Philipp

oh, I see, it looks like we have to insert reset_control_deassert(chip->resets);
just after clk_prepare_enable(chip->cfgr_clk);...

You're absolutely right!

Just realized I may have been too quick with v2. Will wait for more
feedback and send v3.

Best regards,
Artem Shimko