Re: [PATCH net-next 1/6] tools: ynl-gen: bitshift the flag values in the generated code

From: Jakub Kicinski

Date: Mon Oct 13 2025 - 20:53:33 EST


On Mon, 13 Oct 2025 16:49:58 +0000 Asbjørn Sloth Tønnesen wrote:
> Instead of pre-computing the flag values within the code generator,
> then move the bitshift operation into the generated code.
>
> This IMHO makes the generated code read more like handwritten code.

I like it the way it is. The values are irrelevant.

And returning a string from user_value() is quite ugly.