Re: [PATCH 4/5] power: reset: sc27xx: Add support for SC2730 and OF match table

[Baolin Wang]

On 2025/9/30 13:30, Otto Pflüger wrote:
> On Tue, Sep 30, 2025 at 11:30:16AM +0800, Baolin Wang wrote:
> > If I remember correctly, the original driver supported SC2730 and SC2731
> > chips. Are you sure the current changes are still needed? Have you tested
> > them on the SC2730 chip?
> >
> >
> > config POWER_RESET_SC27XX
> >          tristate "Spreadtrum SC27xx PMIC power-off driver"
> >          depends on MFD_SC27XX_PMIC || COMPILE_TEST
> >          help
> >            This driver supports powering off a system through
> >            Spreadtrum SC27xx series PMICs. The SC27xx series
> >            PMICs includes the SC2720, SC2721, SC2723, SC2730
> >            and SC2731 chips.
>
> The driver was hard-coded to use registers 0xc2c and 0xdf0. SC2730 has
> different registers, which were added to the downstream version of the
> driver in [1]. I have tested this with a UMS9230 phone which has an
> SC2730 PMIC according to the device tree.
>
> [1]: https://github.com/MotorolaMobilityLLC/kernel-sprd/commit/6165e1afe3eba33089fecc86767d47af9ab176d6

OK. Thanks.
Reviewed-by: Baolin Wang <baolin.wang@xxxxxxxxxxxxxxxxx>