Re: [PATCH v3 04/10] pmdomain: mediatek: Refactor bus protection regmaps retrieval

From: AngeloGioacchino Del Regno

Date: Tue Oct 14 2025 - 05:59:14 EST


Il 13/10/25 15:41, Sjoerd Simons ha scritto:
Hey,

On Tue, 2025-08-05 at 09:47 +0200, AngeloGioacchino Del Regno wrote:
In preparation to add support for new generation SoCs like MT8196,
MT6991 and other variants, which require to set bus protection on
different busses than the ones found on legacy chips, and to also
simplify and reduce memory footprint of this driver, refactor the
mechanism to retrieve and use the bus protection regmaps.

This is done by removing the three pointers to struct regmap from
struct scpsys_domain (allocated for each power domain) and moving
them to the main struct scpsys (allocated per driver instance) as
an array of pointers to regmap named **bus_prot.

Trying to boot v6.18.0-rc1 on a Genio 700 EVK using the arm64 defconfig,
ends up hanging at boot (seemingly when probing MTU3 and/or mmc, but that
might be a red herring).

Either reverting this patch *or* having CONFIG_MTK_MMSYS builtin rather
then a module seems to solve that.


Thanks for the report.

This is not a problem with this patch specifically, but surely some race condition
that was already present before and that does get uncovered with this one in some
conditions.

Without the devicetree updates (which are not upstream yet) this patch is
fully retaining the legacy functionality 1-to-1.

I'll check what's going on ASAP.

Cheers,
Angelo