Re: stable: commit "cpuidle: menu: Avoid discarding useful information" causes regressions

[Sergey Senozhatsky]

On (25/10/14 11:25), Christian Loehle wrote:
> On 10/14/25 11:23, Sergey Senozhatsky wrote:
> > On (25/10/14 10:50), Christian Loehle wrote:
> >>> Upstream fixup fa3fa55de0d ("cpuidle: governors: menu: Avoid using
> >>> invalid recent intervals data") doesn't address the problems we are
> >>> observing.  Revert seems to be bringing performance metrics back to
> >>> pre-regression levels.
> >>
> >> Any details would be much appreciated.
> >> How do the idle state usages differ with and without
> >> "cpuidle: menu: Avoid discarding useful information"?
> >> What do the idle states look like in your platform?
> > 
> > Sure, I can run tests.  How do I get the numbers/stats
> > that you are asking for?
> 
> Ideally just dump
> cat /sys/devices/system/cpu/cpu*/cpuidle/state*/*
> before and after the test.

OK, got some data for you.  The terminology being used here is as follows:

- 6.1-base
  is 6.1 stable with a9edb700846 "cpuidle: menu: Avoid discarding useful information"

- 6.1-base-fixup
  is 6.1 stable with a9edb700846 and fa3fa55de0d6 "cpuidle: governors:
  menu: Avoid using invalid recent intervals data" cherry-pick

- 6.1-revert
  is 6.1 stable with a9edb700846 reverted (and no fixup commit, obviously)

Just to show the scale of regression, results of some of the benchmarks:

  6.1-base:		84.5
  6.1-base-fixup:	76.5
  6.1-revert:		59.5

  (lower is better, 6.1-revert has the same results as previous stable
  kernels).

Please find  /sys/devices/system/cpu/cpu*/cpuidle/state*/* dumps
attached (6 files).

The cpuidle/state*/* directory structure is as follows (NOTE: dumps
don't contain s2idle subdirs):

/sys/devices/system/cpu/cpu1/cpuidle/
|-- state0
|   |-- above
|   |-- below
|   |-- default_status
|   |-- desc
|   |-- disable
|   |-- latency
|   |-- name
|   |-- power
|   |-- rejected
|   |-- residency
|   |-- time
|   `-- usage
|-- state1
|   |-- above
|   |-- below
|   |-- default_status
|   |-- desc
|   |-- disable
|   |-- latency
|   |-- name
|   |-- power
|   |-- rejected
|   |-- residency
|   |-- s2idle
|   |   |-- time
|   |   `-- usage
|   |-- time
|   `-- usage
|-- state2
|   |-- above
|   |-- below
|   |-- default_status
|   |-- desc
|   |-- disable
|   |-- latency
|   |-- name
|   |-- power
|   |-- rejected
|   |-- residency
|   |-- s2idle
|   |   |-- time
|   |   `-- usage
|   |-- time
|   `-- usage
`-- state3
    |-- above
    |-- below
    |-- default_status
    |-- desc
    |-- disable
    |-- latency
    |-- name
    |-- power
    |-- rejected
    |-- residency
    |-- s2idle
    |   |-- time
    |   `-- usage
    |-- time
    `-- usage

Hope this helps.
0
6290
enabled
CPUIDLE CORE POLL IDLE
0
0
POLL
4294967295
0
0
202367
6897
993
74929
enabled
ACPI FFH MWAIT 0x0
0
1
C1_ACPI
0
0
1
191847713
764099
71722
151
enabled
ACPI FFH MWAIT 0x33
0
253
C2_ACPI
0
0
759
149341875
200291
127362
0
enabled
ACPI FFH MWAIT 0x60
0
1048
C3_ACPI
0
0
3144
541976622
177665
0
5451
enabled
CPUIDLE CORE POLL IDLE
0
0
POLL
4294967295
0
0
190922
5829
958
66733
enabled
ACPI FFH MWAIT 0x0
0
1
C1_ACPI
0
0
1
177872430
750675
65666
114
enabled
ACPI FFH MWAIT 0x33
0
253
C2_ACPI
0
0
759
142974450
189705
132455
0
enabled
ACPI FFH MWAIT 0x60
0
1048
C3_ACPI
0
0
3144
564705824
185014
0
6049
enabled
CPUIDLE CORE POLL IDLE
0
0
POLL
4294967295
0
0
198964
6392
1065
74400
enabled
ACPI FFH MWAIT 0x0
0
1
C1_ACPI
0
0
1
198249007
834971
75131
80
enabled
ACPI FFH MWAIT 0x33
0
253
C2_ACPI
0
0
759
150744820
201077
160850
0
enabled
ACPI FFH MWAIT 0x60
0
1048
C3_ACPI
0
0
3144
524904977
216304
0
5425
enabled
CPUIDLE CORE POLL IDLE
0
0
POLL
4294967295
0
0
170755
5725
918
67471
enabled
ACPI FFH MWAIT 0x0
0
1
C1_ACPI
0
0
1
175937821
711612
62239
125
enabled
ACPI FFH MWAIT 0x33
0
253
C2_ACPI
0
0
759
141196601
184986
124303
0
enabled
ACPI FFH MWAIT 0x60
0
1048
C3_ACPI
0
0
3144
567330625
178220
0
1088
enabled
CPUIDLE CORE POLL IDLE
0
0
POLL
4294967295
0
0
56332
1095
16
699
enabled
ACPI FFH MWAIT 0x0
0
1
C1_ACPI
0
0
1
2701663
19616
699
5
enabled
ACPI FFH MWAIT 0x33
0
253
C2_ACPI
0
0
759
1752251
2211
2398
0
enabled
ACPI FFH MWAIT 0x60
0
1048
C3_ACPI
0
0
3144
45107703
4427
0
1137
enabled
CPUIDLE CORE POLL IDLE
0
0
POLL
4294967295
0
0
52209
1152
29
541
enabled
ACPI FFH MWAIT 0x0
0
1
C1_ACPI
0
0
1
2868784
17342
620
2
enabled
ACPI FFH MWAIT 0x33
0
253
C2_ACPI
0
0
759
1813300
2181
2245
0
enabled
ACPI FFH MWAIT 0x60
0
1048
C3_ACPI
0
0
3144
44950188
4402
0
596
enabled
CPUIDLE CORE POLL IDLE
0
0
POLL
4294967295
0
0
28250
598
44
855
enabled
ACPI FFH MWAIT 0x0
0
1
C1_ACPI
0
0
1
3291276
17545
741
6
enabled
ACPI FFH MWAIT 0x33
0
253
C2_ACPI
0
0
759
2245425
2570
3882
0
enabled
ACPI FFH MWAIT 0x60
0
1048
C3_ACPI
0
0
3144
43040364
7244
0
548
enabled
CPUIDLE CORE POLL IDLE
0
0
POLL
4294967295
0
0
26334
553
29
825
enabled
ACPI FFH MWAIT 0x0
0
1
C1_ACPI
0
0
1
2741500
13132
593
4
enabled
ACPI FFH MWAIT 0x33
0
253
C2_ACPI
0
0
759
1661517
2068
2021
0
enabled
ACPI FFH MWAIT 0x60
0
1048
C3_ACPI
0
0
3144
45328304
4276
0
5622
enabled
CPUIDLE CORE POLL IDLE
0
0
POLL
4294967295
0
0
214428
5842
1092
68073
enabled
ACPI FFH MWAIT 0x0
0
1
C1_ACPI
0
0
1
181308931
749748
66083
76
enabled
ACPI FFH MWAIT 0x33
0
253
C2_ACPI
0
0
759
141979962
189347
126079
0
enabled
ACPI FFH MWAIT 0x60
0
1048
C3_ACPI
0
0
3144
591520177
179133
0
5584
enabled
CPUIDLE CORE POLL IDLE
0
0
POLL
4294967295
0
0
192643
5890
1060
59709
enabled
ACPI FFH MWAIT 0x0
0
1
C1_ACPI
0
0
1
167257109
736458
59775
90
enabled
ACPI FFH MWAIT 0x33
0
253
C2_ACPI
0
0
759
131493187
173952
132636
0
enabled
ACPI FFH MWAIT 0x60
0
1048
C3_ACPI
0
0
3144
610763314
186438
0
5158
enabled
CPUIDLE CORE POLL IDLE
0
0
POLL
4294967295
0
0
166999
5599
1118
65134
enabled
ACPI FFH MWAIT 0x0
0
1
C1_ACPI
0
0
1
183770715
815437
67570
231
enabled
ACPI FFH MWAIT 0x33
0
253
C2_ACPI
0
0
759
141702864
185642
153923
0
enabled
ACPI FFH MWAIT 0x60
0
1048
C3_ACPI
0
0
3144
566152535
212196
0
4503
enabled
CPUIDLE CORE POLL IDLE
0
0
POLL
4294967295
0
0
162421
4691
1082
60230
enabled
ACPI FFH MWAIT 0x0
0
1
C1_ACPI
0
0
1
164979305
711633
58288
69
enabled
ACPI FFH MWAIT 0x33
0
253
C2_ACPI
0
0
759
133851510
175178
124831
0
enabled
ACPI FFH MWAIT 0x60
0
1048
C3_ACPI
0
0
3144
622333109
180035
0
1404
enabled
CPUIDLE CORE POLL IDLE
0
0
POLL
4294967295
0
0
70772
1415
40
1141
enabled
ACPI FFH MWAIT 0x0
0
1
C1_ACPI
0
0
1
3929597
21223
805
27
enabled
ACPI FFH MWAIT 0x33
0
253
C2_ACPI
0
0
759
2397281
2650
2854
0
enabled
ACPI FFH MWAIT 0x60
0
1048
C3_ACPI
0
0
3144
55995957
5133
0
1291
enabled
CPUIDLE CORE POLL IDLE
0
0
POLL
4294967295
0
0
61527
1296
36
717
enabled
ACPI FFH MWAIT 0x0
0
1
C1_ACPI
0
0
1
3418438
21543
681
23
enabled
ACPI FFH MWAIT 0x33
0
253
C2_ACPI
0
0
759
1824754
2169
2069
0
enabled
ACPI FFH MWAIT 0x60
0
1048
C3_ACPI
0
0
3144
55967984
4116
0
740
enabled
CPUIDLE CORE POLL IDLE
0
0
POLL
4294967295
0
0
34892
749
36
986
enabled
ACPI FFH MWAIT 0x0
0
1
C1_ACPI
0
0
1
3480340
19501
722
24
enabled
ACPI FFH MWAIT 0x33
0
253
C2_ACPI
0
0
759
2081421
2427
3127
0
enabled
ACPI FFH MWAIT 0x60
0
1048
C3_ACPI
0
0
3144
52930672
6478
0
877
enabled
CPUIDLE CORE POLL IDLE
0
0
POLL
4294967295
0
0
40376
886
40
922
enabled
ACPI FFH MWAIT 0x0
0
1
C1_ACPI
0
0
1
3128952
14648
685
28
enabled
ACPI FFH MWAIT 0x33
0
253
C2_ACPI
0
0
759
1810975
2150
1922
0
enabled
ACPI FFH MWAIT 0x60
0
1048
C3_ACPI
0
0
3144
57628110
4045
0
5553
enabled
CPUIDLE CORE POLL IDLE
0
0
POLL
4294967295
0
0
203089
5705
1175
52097
enabled
ACPI FFH MWAIT 0x0
0
1
C1_ACPI
0
0
1
158368245
698746
96141
132
enabled
ACPI FFH MWAIT 0x33
0
253
C2_ACPI
0
0
759
144897039
217063
240214
0
enabled
ACPI FFH MWAIT 0x60
0
1048
C3_ACPI
0
0
3144
658034398
304378
0
4685
enabled
CPUIDLE CORE POLL IDLE
0
0
POLL
4294967295
0
0
165393
5005
1061
36293
enabled
ACPI FFH MWAIT 0x0
0
1
C1_ACPI
0
0
1
127609773
617707
82647
45
enabled
ACPI FFH MWAIT 0x33
0
253
C2_ACPI
0
0
759
130285693
193009
235242
0
enabled
ACPI FFH MWAIT 0x60
0
1048
C3_ACPI
0
0
3144
697297998
302515
0
4881
enabled
CPUIDLE CORE POLL IDLE
0
0
POLL
4294967295
0
0
176017
5187
1066
38482
enabled
ACPI FFH MWAIT 0x0
0
1
C1_ACPI
0
0
1
139032412
680004
92532
118
enabled
ACPI FFH MWAIT 0x33
0
253
C2_ACPI
0
0
759
139225500
205414
278284
0
enabled
ACPI FFH MWAIT 0x60
0
1048
C3_ACPI
0
0
3144
676711855
349678
0
4195
enabled
CPUIDLE CORE POLL IDLE
0
0
POLL
4294967295
0
0
141494
4691
994
38463
enabled
ACPI FFH MWAIT 0x0
0
1
C1_ACPI
0
0
1
129367024
606975
77981
164
enabled
ACPI FFH MWAIT 0x33
0
253
C2_ACPI
0
0
759
131118949
188932
224524
0
enabled
ACPI FFH MWAIT 0x60
0
1048
C3_ACPI
0
0
3144
710862747
294570
0
1556
enabled
CPUIDLE CORE POLL IDLE
0
0
POLL
4294967295
0
0
80877
1564
64
5929
enabled
ACPI FFH MWAIT 0x0
0
1
C1_ACPI
0
0
1
13453935
50505
8267
6
enabled
ACPI FFH MWAIT 0x33
0
253
C2_ACPI
0
0
759
11884260
18354
23514
0
enabled
ACPI FFH MWAIT 0x60
0
1048
C3_ACPI
0
0
3144
39687648
27556
0
1156
enabled
CPUIDLE CORE POLL IDLE
0
0
POLL
4294967295
0
0
52200
1169
49
2475
enabled
ACPI FFH MWAIT 0x0
0
1
C1_ACPI
0
0
1
7112506
34469
4620
9
enabled
ACPI FFH MWAIT 0x33
0
253
C2_ACPI
0
0
759
6924734
10532
17523
0
enabled
ACPI FFH MWAIT 0x60
0
1048
C3_ACPI
0
0
3144
40831690
21574
0
875
enabled
CPUIDLE CORE POLL IDLE
0
0
POLL
4294967295
0
0
44128
886
33
3029
enabled
ACPI FFH MWAIT 0x0
0
1
C1_ACPI
0
0
1
7847523
33257
4641
9
enabled
ACPI FFH MWAIT 0x33
0
253
C2_ACPI
0
0
759
8436592
11907
22914
0
enabled
ACPI FFH MWAIT 0x60
0
1048
C3_ACPI
0
0
3144
46892106
27811
0
872
enabled
CPUIDLE CORE POLL IDLE
0
0
POLL
4294967295
0
0
39337
877
41
3402
enabled
ACPI FFH MWAIT 0x0
0
1
C1_ACPI
0
0
1
8340025
32610
4316
8
enabled
ACPI FFH MWAIT 0x33
0
253
C2_ACPI
0
0
759
9335908
12692
19002
0
enabled
ACPI FFH MWAIT 0x60
0
1048
C3_ACPI
0
0
3144
47793881
23941