Re: [PATCH v3 3/3] dt-bindings: regulator: Add MAX77675 regulator binding

[Mark Brown]

On Tue, Oct 14, 2025 at 10:14:15AM +0200, Krzysztof Kozlowski wrote:
> On 14/10/2025 07:31, Joan-Na-adi wrote:

> > +  maxim,en-mode:
> > +    description: |
> > +      Enable mode configuration.
> > +      "push-button"  - Push button
> > +      "slide-switch" - Slide switch
> > +      "logic" - Logic mode

> You just repeat the name in the description. Say something useful.

Do you have concrete suggestions there?  I can see dropping the
descriptions entirely but otherwise I'm not sure there's much to
usefully add.

> > +  maxim,latency-mode:
> > +    description: |
> > +      Latency mode for voltage transition:
> > +      "high" - High latency (100μs)
> > +      "low"  - Low latency (10μs)

> So use values 100 or 10, and proper type (-us)

Without knowing the device specifics at all I rather suspect those
numbers are more ballparks than specifics.

> > +  maxim,dvs-slew-rate-mv-per-us:

> ... like here.

> > +    description: |
> > +      Dynamic rising slew rate for output voltage transitions, in mV/μs.

> Except you said mv/us, not us. Confusing.

That's what I'd expect for a slew rate?  It's the speed with which the
device ramps between voltages during voltage transitions, mV/us is a
perfectly normal unit for that.

Attachment: signature.asc
Description: PGP signature