Re: [PATCH -v2 1/2] mm: add spurious fault fixing support for huge pmd

[David Hildenbrand]

On 14.10.25 16:49, Lorenzo Stoakes wrote:
> On Tue, Oct 14, 2025 at 04:38:05PM +0200, David Hildenbrand wrote:
> > > 		/* Skip spurious TLB flush for retried page fault */
> > > 		if (vmf->flags & FAULT_FLAG_TRIED)
> > > 			goto unlock;
> > > 		/*
> > > 		 * This is needed only for protection faults but the arch code
> > > 		 * is not yet telling us if this is a protection fault or not.
> > > 		 * This still avoids useless tlb flushes for .text page faults
> > > 		 * with threads.
> > > 		 */
> > > 		if (vmf->flags & FAULT_FLAG_WRITE)
> > > 			flush_tlb_fix_spurious_fault(vmf->vma, vmf->address,
> > > 						     vmf->pte);
> > >
> > >
> > > So I don't see why it's so egregious to have the equivalent here, or actually
> > > ideally to abstract the code entirely.
> >
> > Let's definitely not duplicate such comments whereby one instance will end
> > up bitrotting.
>
> We're duplicating the code in two places, how would that bitrot happen exactly?

Often we adjust/fix comments to make scenarios/conditions clearer or 
extend them to cover some new conditions.

So even without any code changes people will just ignore to update other 
comments.

Code you can at least test with the hope to find inconsistencies.

So copying rather large comments is usually never the answer :)

Well, just like copying larger chunks of code, agreed.

--
Cheers

David / dhildenb