RE: [PATCH] Hid: Intel-thc-hid: Intel-quickspi: switch first interrupt from level to edge detection

[Xu, Even]

Thanks Jiri!

Best Regards,
Even Xu

> -----Original Message-----
> From: Jiri Kosina <jikos@xxxxxxxxxx>
> Sent: Tuesday, October 14, 2025 5:29 PM
> To: Xu, Even <even.xu@xxxxxxxxx>
> Cc: bentiss@xxxxxxxxxx; srinivas.pandruvada@xxxxxxxxxxxxxxx; linux-
> input@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Zhang, Rui1
> <rui1.zhang@xxxxxxxxx>
> Subject: Re: [PATCH] Hid: Intel-thc-hid: Intel-quickspi: switch first interrupt from
> level to edge detection
> 
> On Fri, 19 Sep 2025, Even Xu wrote:
> 
> > The original implementation used level detection for the first
> > interrupt after device reset to avoid potential interrupt line noise
> > and missed interrupts during the initialization phase. However, this
> > approach introduced unintended side effects when tested with certain
> > touch panels,
> > including:
> >  - Delayed hardware interrupt response
> >  - Multiple spurious interrupt triggers
> >
> > Switching back to edge detection for the first interrupt resolves
> > these issues while maintaining reliable interrupt handling.
> >
> > Extensive testing across multiple platforms with touch panels from
> > various vendors confirms this change introduces no regressions.
> >
> > Fixes: 9d8d51735a3a ("HID: intel-thc-hid: intel-quickspi: Add HIDSPI
> > protocol implementation")
> > Tested-by: Rui Zhang <rui1.zhang@xxxxxxxxx>
> > Signed-off-by: Even Xu <even.xu@xxxxxxxxx>
> 
> Applied to hid.git#for-6.18/upstream-fixes, thanks.
> 
> --
> Jiri Kosina
> SUSE Labs