Re: [PATCH] arm64: defconfig: Drop duplicate CONFIG_OMAP_USB2 entry

[Lad, Prabhakar]

On Tue, Oct 14, 2025 at 11:03 PM Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote:
>
> On 15/10/2025 00:00, Krzysztof Kozlowski wrote:
> > On 14/10/2025 20:20, Prabhakar wrote:
> >> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
> >>
> >> CONFIG_OMAP_USB2 is already enabled as a module in the default defconfig
> >> since commit 8a703a728a745 ("arm64: defconfig: Enable USB2 PHY Driver").
> >> Remove the duplicate entry to fix the following warning:
> >>
> >>     arch/arm64/configs/defconfig:1705:warning: override: reassigning to symbol OMAP_USB2
> >>
> >> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
> >> ---
> >>  arch/arm64/configs/defconfig | 1 -
> >>  1 file changed, 1 deletion(-)
> >>
> >> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> >> index e401915e2f2f..478ca72c0aeb 100644
> >> --- a/arch/arm64/configs/defconfig
> >> +++ b/arch/arm64/configs/defconfig
> >> @@ -1702,7 +1702,6 @@ CONFIG_PHY_UNIPHIER_USB3=y
> >>  CONFIG_PHY_TEGRA_XUSB=y
> >>  CONFIG_PHY_AM654_SERDES=m
> >>  CONFIG_PHY_J721E_WIZ=m
> >> -CONFIG_OMAP_USB2=m
> >
> > I don't understand. There is no such line in defconfig. Which next are
> > you referring to? Was it just broken in Renesas tree?
> >
> Ah, no, it got broken by Michal. You should add proper fixes tag which
> results in automatic Cc.
>
Sorry I missed that, I'll add the below and send a v2.

Fixes: 91fe3315cdf9f ("arm64: defconfig: Enable missing AMD/Xilinx drivers")

Cheers,
Prabhakar

> @Michal,
>
> Are you sure your commit did not introduce more of such issues?
>
> Best regards,
> Krzysztof