Re: [PATCH net-next 2/9] hinic3: Add PF management interfaces

[Markus Elfring]

> To: Fan Gong …

Please reconsider the distribution of recipient information between message fields
once more.


…
> +++ b/drivers/net/ethernet/huawei/hinic3/hinic3_mgmt.c
> @@ -3,19 +3,325 @@
…
> +static void mgmt_resp_msg_handler(struct hinic3_msg_pf_to_mgmt *pf_to_mgmt,
> +				  struct hinic3_recv_msg *recv_msg)
> +{
…
> +	spin_lock(&pf_to_mgmt->sync_event_lock);
> +	if (recv_msg->msg_id != pf_to_mgmt->sync_msg_id) {
…
> +	}
> +	spin_unlock(&pf_to_mgmt->sync_event_lock);
> +}
…

Will development interests grow to apply a call like “scoped_guard(spinlock, &pf_to_mgmt->sync_event_lock)”?
https://elixir.bootlin.com/linux/v6.17.1/source/include/linux/spinlock.h#L565-L567

Regards,
Markus