Re: [PATCH v2 1/2] drivers/base/node: Fold register_node() into register_one_node()

[David Hildenbrand]

On 14.10.25 17:39, Donet Tom wrote:
> The function register_node() is only called from register_one_node().
> This patch folds register_node() into its only caller and renames
> register_one_node() to register_node().
>
> This reduces unnecessary indirection and simplifies the code structure.
> No functional changes are introduced.
>
> Acked-by: Mike Rapoport (Microsoft) <rppt@xxxxxxxxxx>
> Signed-off-by: Donet Tom <donettom@xxxxxxxxxxxxx>
> ---
[...]

>   /**
>    * unregister_node - unregister a node device
>    * @node: node going away
> @@ -907,7 +880,13 @@ void register_memory_blocks_under_node_hotplug(int nid, unsigned long start_pfn,
>   }
>   #endif /* CONFIG_MEMORY_HOTPLUG */
>   
> -int register_one_node(int nid)
> +/**
> + * register_node - Initialize and register the node device.
> + * @nid - Node number to use when creating the device.

I assume that should be "@nid: ..." to silence the warning.

Acked-by: David Hildenbrand <david@xxxxxxxxxx>

--
Cheers

David / dhildenb