Re: [PATCH 1/2] arm: dts: ti: Adds device tree nodes for PRU Cores, IEP and eCAP modules of PRU-ICSS2 Instance.

[Parvathi Pudi]

Hi,

>> +				interrupt-names = "rx", "emac_ptp_tx",
>> +								"hsr_ptp_tx";
> 
> Something looks wrong with the indentation here. The same happens in
> at least one other place.
> 

we will correct the indentation of the interrupt-names property to properly
align the continuation line as shown below.

interrupt-names = "rx", "emac_ptp_tx",
                  "hsr_ptp_tx";

We will make sure to address this in all the applicable places and include
this fix in the next version.


>> +&pruss2_mdio {
>> +	status = "okay";
>> +	pruss2_eth0_phy: ethernet-phy@0 {
>> +		reg = <0>;
>> +		interrupt-parent = <&gpio3>;
>> +		interrupts = <30 IRQ_TYPE_EDGE_FALLING>;
>> +	};
>> +
>> +	pruss2_eth1_phy: ethernet-phy@1 {
>> +		reg = <1>;
>> +		interrupt-parent = <&gpio3>;
>> +		interrupts = <31 IRQ_TYPE_EDGE_FALLING>;
>> +	};
> 
> 
> PHY interrupts are 99% level, not edge, because they represent an
> interrupt controller in the PHY, and you need to clear all the
> interrupts in the controller before it deasserts the interrupt pin.
> 
>    Andrew


Sure, we will check and come back with more details on this.


Thanks and Regards,
Parvathi.