Re: [PATCH v2 4/4] net: mdio: reset PHY before attempting to access registers in fwnode_mdiobus_register_phy

[Simon Horman]

On Wed, Oct 15, 2025 at 03:45:03PM +0200, Buday Csaba wrote:

...

>  drivers/net/mdio/fwnode_mdio.c | 37 +++++++++++++++++++++++++++++++++-
>  1 file changed, 36 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/mdio/fwnode_mdio.c b/drivers/net/mdio/fwnode_mdio.c
> index ba7091518..6987b1a51 100644
> --- a/drivers/net/mdio/fwnode_mdio.c
> +++ b/drivers/net/mdio/fwnode_mdio.c
> @@ -114,6 +114,38 @@ int fwnode_mdiobus_phy_device_register(struct mii_bus *mdio,
>  }
>  EXPORT_SYMBOL(fwnode_mdiobus_phy_device_register);
>  
> +/**
> + * fwnode_reset_phy() - Hard-reset a PHY before registration

Hi Buday,

This is not a full review. But as this is a Kernel doc (a comment in Kernel
doc format), it should also document:

1. The function arguments:

  * @bus: ...
  * @addr: ...
  * @phy_node: ...

2. The return value:

  * Returns: ...

Flagged by ./scripts/kernel-doc -none -Wall

Thanks!

> + */
> +static int fwnode_reset_phy(struct mii_bus *bus, u32 addr,

...

-- 
pw-bot: cr