Re: [PATCH] media: qcom: camss: Use a macro to specify the initial buffer count

[Bryan O'Donoghue]

On 15/10/2025 20:22, Vladimir Zapolskiy wrote:
> On 10/15/25 05:42, Hangxiang Ma wrote:
> > Replace the hardcoded buffer count value with a macro to enable
> > operating on these buffers elsewhere in the CAMSS driver based on this
> > count. Some of the hardware architectures require deferring the AUP and
> > REG update until after the CSID configuration and this macro is expected
> > to be useful in such scenarios.
> >
> > Signed-off-by: Hangxiang Ma <hangxiang.ma@xxxxxxxxxxxxxxxx>
> > ---
> > This change use a global macro to specify the initial buffer count. It
> > meets the requirement that some hardware architectures need to defer the
> > AUP and REG update to CSID configuration stage.
>
> Both the commit message and the explanation above brings no clarity on
> the necessity of this change at all.

I don't agree. Removing a hard-coded value for a define is an obviously 
correct change.

> This is a dangling useless commit, if you'd like to connect it to
> something meaningful, please include it into a series.

No. It is fine as is.

---
bod