Re: [PATCH v2] dt-bindings: iommu: qcom_iommu: Allow 'tbu' clock

From: Dmitry Baryshkov

Date: Wed Oct 15 2025 - 16:11:00 EST


On Wed, Oct 15, 2025 at 05:48:05PM +0100, Robin Murphy wrote:
> On 2025-10-15 5:41 pm, Konrad Dybcio wrote:
> > From: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>
> >
> > Some IOMMUs on some platforms (there doesn't seem to be a good denominator

It would be nice to provide some examples here.

> > for this) require the presence of a third clock, specifically for
> > accessing the IOMMU's Translation Buffer Unit (TBU). Allow it.
>
> Hmmm, but isn't the only thing that accesses TBUs the consumer of the
> qcom,tbu binding, which already has its own clock?

qcom,tbu is only defined for normal arm,mmu-500 platforms. Here Konrad
is fixing the older and more obscure Qualcomm virtual MMU device.

>
> Thanks,
> Robin.
>
> > Reviewed-by: Rob Herring <robh@xxxxxxxxxx>
> > Signed-off-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>
> > ---
> > Resending from a 2023 megaseries, no changes
> >
> > v1: https://lore.kernel.org/lkml/20230627-topic-more_bindings-v1-7-6b4b6cd081e5@xxxxxxxxxx/
> > ---
> > Documentation/devicetree/bindings/iommu/qcom,iommu.yaml | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
--
With best wishes
Dmitry