Re: [PATCH v4 1/2] dt-bindings: media: qcom,qcs8300-camss: Add missing power supplies

[Bryan O'Donoghue]

On 15/10/2025 19:41, Vladimir Zapolskiy wrote:
> On 10/15/25 16:01, Vikram Sharma wrote:
> > Add support for vdda-phy-supply and vdda-pll-supply in the QCS8300
> > CAMSS binding to reflect camera sensor hardware requirements.
>
> What are "camera sensor hardware requirements"? You do add properties
> to the ISP.
>
> > Co-developed-by: Nihal Kumar Gupta <quic_nihalkum@xxxxxxxxxxx>
> > Signed-off-by: Nihal Kumar Gupta <quic_nihalkum@xxxxxxxxxxx>
> > Signed-off-by: Vikram Sharma <quic_vikramsa@xxxxxxxxxxx>
> > ---
> >   .../bindings/media/qcom,qcs8300-camss.yaml          | 13 +++++++++++++
> >   1 file changed, 13 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/media/qcom,qcs8300- 
> > camss.yaml b/Documentation/devicetree/bindings/media/qcom,qcs8300- 
> > camss.yaml
> > index 80a4540a22dc..dce0a1fcb10c 100644
> > --- a/Documentation/devicetree/bindings/media/qcom,qcs8300-camss.yaml
> > +++ b/Documentation/devicetree/bindings/media/qcom,qcs8300-camss.yaml
> > @@ -120,6 +120,14 @@ properties:
> >       items:
> >         - const: top
> > +  vdda-phy-supply:
> > +    description:
> > +      Phandle to a regulator supply to PHY core block.
>
> What is "PHY core block" here?

I mean come on, I think the meaning is clear.

> > +
> > +  vdda-pll-supply:
> > +    description:
> > +      Phandle to 1.8V regulator supply to PHY refclk pll block.
>
> This is a copy-paste example of a known to be wrong pattern.

You're right about the name, please align with this commit

git show cba308979b012664c7fe7c5baa818fcb68e86363

Thanks for spotting.

---
bod