Re: [PATCH 2/3] rust: pci: move I/O infrastructure to separate file

From: Bjorn Helgaas

Date: Wed Oct 15 2025 - 18:58:29 EST


On Wed, Oct 15, 2025 at 08:14:30PM +0200, Danilo Krummrich wrote:
> Move the PCI I/O infrastructure to a separate sub-module in order to
> keep things organized.

> +++ b/rust/kernel/pci/io.rs

> +/// A PCI BAR to perform I/O-Operations on.
> ...
> +/// memory mapped PCI bar and its size.
> ...
> + /// `ioptr` must be a valid pointer to the memory mapped PCI bar number `num`.

I know this is just a move, but "BAR" vs "bar" usage is inconsistent.
I think "BAR" is clearer in comments.

> + /// Mapps an entire PCI-BAR after performing a region-request on it. I/O operation bound checks
> ...
> + /// Mapps an entire PCI-BAR after performing a region-request on it.

Similarly, s/Mapps/Maps/ and s/PCI-BAR/PCI BAR/