Re: [PATCH] rtc: tegra: Add ACPI support

[Andy Shevchenko]

On Fri, Sep 19, 2025 at 04:42:32PM +0530, Kartik Rajput wrote:
> Add ACPI support for Tegra RTC, which is available on Tegra241 and
> Tegra410. Both Tegra241 and Tegra410 use the same ACPI ID 'NVDA0280'.
> The RTC clock is configured by UEFI before the kernel boots.

...

> +#include <linux/acpi.h>

No use.

...

> +static const struct acpi_device_id tegra_rtc_acpi_match[] = {
> +	{ "NVDA0280", 0 },

Drop redundant ', 0' part.

> +	{ }
> +};

...

> +	if (is_of_node(dev_fwnode(&pdev->dev))) {

Simple dev_of_node() will work here

> +		info->clk = devm_clk_get(&pdev->dev, NULL);
> +		if (IS_ERR(info->clk))
> +			return PTR_ERR(info->clk);
>  
> +		ret = clk_prepare_enable(info->clk);
> +		if (ret < 0)
> +			return ret;
> +	}

...

>  disable_clk:
> -	clk_disable_unprepare(info->clk);
> +	if (is_of_node(dev_fwnode(&pdev->dev)))
> +		clk_disable_unprepare(info->clk);

Redundant change. CLK APIs are NULL aware.

...

> -	clk_disable_unprepare(info->clk);
> +	if (is_of_node(dev_fwnode(&pdev->dev)))
> +		clk_disable_unprepare(info->clk);

Ditto.

-- 
With Best Regards,
Andy Shevchenko