Re: [PATCH 06/22] smb: move SMB1_PROTO_NUMBER to common/cifsglob.h

[chenxiaosong]

Yes, "cpu_to_le32()" should not be present, I'll send v2 patchset.

Thanks for reply.

On 2025/10/12 23:21, Christophe JAILLET wrote:
> Le 12/10/2025 à 17:08, chenxiaosong@xxxxxxxxxxxxxxxx a écrit :

> >       /* does it have the right SMB "signature" ? */
> > -    if (*(__le32 *) smb->Protocol != cpu_to_le32(0x424d53ff)) {
> > +    if (*(__le32 *) smb->Protocol != cpu_to_le32(SMB1_PROTO_NUMBER)) {
>
> Should this be SMB1_PROTO_NUMBER?
> (without cpu_to_le32())
>
> CJ