Re: [PATCH v3] audit: include source and destination ports to NETFILTER_PKT
From: Paul Moore
Date: Mon Oct 13 2025 - 16:27:02 EST
On Mon, Oct 13, 2025 at 3:11 PM Ricardo Robaina <rrobaina@xxxxxxxxxx> wrote:
> On Mon, Oct 13, 2025 at 3:51 PM Paul Moore <paul@xxxxxxxxxxxxxx> wrote:
> > On Mon, Oct 13, 2025 at 2:48 PM Paul Moore <paul@xxxxxxxxxxxxxx> wrote:
> > > On Fri, Oct 3, 2025 at 11:43 AM Ricardo Robaina <rrobaina@xxxxxxxxxx> wrote:
> > > > On Sat, Sep 27, 2025 at 7:45 AM Florian Westphal <fw@xxxxxxxxx> wrote:
> > > > > Ricardo Robaina <rrobaina@xxxxxxxxxx> wrote:
> > >
> > > ...
> > >
> > > > > Maybe Paul would be open to adding something like audit_log_packet() to
> > > > > kernel/audit.c and then have xt_AUDIT.c and nft_log.c just call the
> > > > > common helper.
> > > >
> > > > It sounds like a good idea to me. What do you think, Paul?
> > >
> > > Seems like a good idea to me too.
> >
> > A quick follow-up to this ... when you are doing the work Ricardo,
> > please do this as a two patch patchset; the first patch should
> > introduce a new common function called by both audit_tg() and
> > nft_log_eval_audit(), and the second patch should add new port
> > information to the audit record.
>
> Thanks for the tip, Paul! I'll work on it next week.
Great, thanks :)
--
paul-moore.com