Re: [PATCH] dt-bindings: watchdog: Convert marvell,orion-wdt to DT schema
From: Rob Herring
Date: Tue Oct 14 2025 - 18:33:35 EST
On Tue, Oct 14, 2025 at 3:22 PM Sander Vanheule <sander@xxxxxxxxxxxxx> wrote:
>
> Hi Rob,
>
> On Mon, 2025-10-13 at 16:31 -0500, Rob Herring (Arm) wrote:
> > -Clocks required for compatibles = "marvell,orion-wdt",
> > - "marvell,armada-370-wdt":
> > -- clocks : Must contain a single entry describing the clock input
> > -
> > -Clocks required for compatibles = "marvell,armada-xp-wdt"
> > - "marvell,armada-375-wdt"
> > - "marvell,armada-380-wdt":
> > -- clocks : Must contain an entry for each entry in clock-names.
> > -- clock-names : Must include the following entries:
> > - "nbclk" (L2/coherency fabric clock),
> > - "fixed" (Reference 25 MHz fixed-clock).
>
> > + clocks:
> > + minItems: 1
> > + items:
> > + - description: Reference 25 MHz fixed-clock supply.
> > + - description: L2/coherency fabric clock input ("nbclk").
> > +
> > + clock-names:
> > + minItems: 1
> > + items:
> > + - const: nbclk
> > + - const: fixed
>
> Shouldn't the "clock-names" items be in the same order as the "clocks" items?
> (With nbclk first)
Ah yes, I flipped the order of the names to match the .dts files, but
not clocks.
Also, I found there is a 2nd interrupt in some cases.
Rob