Re: [PATCH RESEND v4 07/10] PM: EM: Implement em_nl_get_pd_table_doit()

[Changwoo Min]

On 10/10/25 19:01, Lukasz Luba wrote:
> On 9/21/25 04:19, Changwoo Min wrote:
> > When a userspace requests EM_CMD_GET_PD_TABLE with an ID of a 
> > performancei
>
> s/performancei/performance/

Will fix it. Thanks!

[...]

> >   int em_nl_get_pd_table_doit(struct sk_buff *skb, struct genl_info 
> > *info)
> >   {
> > -    return -EOPNOTSUPP;
> > +    struct sk_buff *msg;
> > +    struct em_perf_domain *pd;
> > +    void *hdr;
> > +    int cmd = info->genlhdr->cmd;
> > +    int msg_sz, ret = -EMSGSIZE;
>
> Please put them in the reverse christmas tree order.

Sure, will fix it as suggested in the next version.

Regards,
Changwoo Min

> After fixing that cosmetic thing you can add:
>
> Reviewed-by: Lukasz Luba <lukasz.luba@xxxxxxx>