Re: [RFC PATCH 2/3] firmware: smccc: LFA: refactor, add device node support

[Vedashree Vidwans]

On 10/9/25 01:13, Sudeep Holla wrote:
> External email: Use caution opening links or attachments
>
>
> On Wed, Oct 08, 2025 at 07:09:06PM +0000, Vedashree Vidwans wrote:
> > - Add support for LFA device node in the kernel driver. Implement
> > probe() to register LFA interrupt and threaded interrupt service
> > function.
> > - CPUs will be rendezvoused during activation.
> > - On IRQ, driver will query FW components then triggers activation of
> > capable and pending components.
> > - Mutex synchronization is implemented to avoid concurrent LFA updates
> > through interrupt and sysfs interfaces.
> > - Refactor LFA CANCEL logic into independent lfa_cancel() function.
> > - Enhance PRIME/ACTIVATION functions to touch watchdog and implement
> > timeouts.
> >
> > Signed-off-by: Vedashree Vidwans <vvidwans@xxxxxxxxxx>
> > ---
> >   drivers/firmware/smccc/lfa_fw.c | 299 ++++++++++++++++++++++++++++----
>
> I was expecting to the devicetree binding based on $subject but no.
> So this patch can't be reviewed without one.
>
> --
> Regards,
> Sudeep

Thank you for your comments, I will include the devicetree binding
in the next iteration.

Regards,
Veda