Re: [PATCH v2 1/1] riscv: dts: spacemit: add Ethernet and PDMA to OrangePi RV2
From: Michael Opdenacker
Date: Fri Oct 24 2025 - 01:37:10 EST
Hi Conor
Thanks for the review!
On 10/23/25 20:30, Conor Dooley wrote:
On Thu, Oct 23, 2025 at 01:58:22PM +0800, Vivian Wang wrote:
Thank you so much for the patch and testing results. Only some nitpicksI don't think this matters at all, the git tooling at least doesn't
follow.
On 10/23/25 04:18, michael.opdenacker@xxxxxxxxxxxxxx wrote:
From: Michael Opdenacker <michael.opdenacker@xxxxxxxxxxxxxx>Firstly, it is usually spelt "Cc:", with one upper-case C and one
The OrangePi RV2 board ships two RGMII ethernet ports.
Each has an external Motorcomm YT8531C PHY attached, the PHY uses GPIO
for reset pin control.
Enable PDMA for the SpacemiT K1-based SoC in the OrangePi RV2 board.
Signed-off-by: Michael Opdenacker <michael.opdenacker@xxxxxxxxxxxxxx>
CC: Emil Renner Berthing <emil.renner.berthing@xxxxxxxxx>
CC: Yixun Lan <dlan@xxxxxxxxxx>
CC: Vivian Wang <wangruikang@xxxxxxxxxxx>
lower-case c.
care.
Secondly, "Cc:" should not be necessary in the patch/commit message.If people want to handle CC lists by putting it in the patches (it's
From Documentation/process/submitting-patches.rst:
If a person has had the opportunity to comment on a patch, but has not
provided such comments, you may optionally add a ``Cc:`` tag to the patch.
This tag documents that potentially interested parties have been included in
the discussion.
If you look through the git logs of Linux, Cc tags are really not a
regular occurrence except those marking patches as suitable for
backporting to stable.
what I do when I have no cover letter) just put them after the --- line
and git send-email will still pick the CCs up but they won't end up in
the history.
Oh yes, that was my mistake. The CCs were never intended to make it to the final commits.
Thanks!
Michael.
--
Michael Opdenacker
Root Commit
Yocto Project and OpenEmbedded Training course - Learn by doing:
https://rootcommit.com/training/yocto/