Re: [PATCH v5 2/2] mmc: sdhci-of-dwcmshc: Add support for Eswin EIC7700

From: Adrian Hunter

Date: Fri Oct 24 2025 - 02:37:11 EST


On 24/10/2025 06:19, 何欢 wrote:
> Hi Adrian,
>
> Thank you very much for your Acked-by and the review!
>
>> On 19/10/2025 14:53, hehuan1@xxxxxxxxxxxxxxxxxx wrote:
>>> From: Huan He <hehuan1@xxxxxxxxxxxxxxxxxx>
>>>
>>> Add support for the mmc controller in the Eswin EIC7700 with the new
>>> compatible "eswin,eic7700-dwcmshc". Implement custom sdhci_ops for
>>> set_clock, reset, set_uhs_signaling, platform_execute_tuning.
>>>
>>> Signed-off-by: Huan He <hehuan1@xxxxxxxxxxxxxxxxxx>
>>
>> Noting that the dt-bindings patch still seems to have issues,
>> for this patch, anyway:
>>
>> Acked-by: Adrian Hunter <adrian.hunter@xxxxxxxxx>
>
> I recieved an dt_binding_check error report:
> https://lore.kernel.org/all/176096011380.22917.1988679321096076522.robh@xxxxxxxxxx/
>
> It seems the error has nothing to do with MMC, but is related to the
> Ethernet binding (eswin,eic7700-eth.yaml), that was pushed by us and
> applied recently, link:
> https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/?id=888bd0eca93c
>
> We're fixing this issue for the Ethernet. The Ethernet patch with
> this bug fix will be sent out later.
That seems OK, but it is up to Ulf now.