Re: [PATCH v2 18/20] rv: Add support for per-object monitors in DA/HA
From: Gabriele Monaco
Date: Fri Oct 24 2025 - 05:20:46 EST
On Thu, 2025-10-23 at 14:36 +0200, Nam Cao wrote:
> Gabriele Monaco <gmonaco@xxxxxxxxxx> writes:
> > Ignoring the vagueness of the name, the two implementations of this hook are
> > to call an allocation (yes, always conditionally) or just assign the target
> > to a pre-allocated storage.
> > Your suggestion of da_monitor_prepare_storage might fit both descriptions.
>
> Now that I have grasped (or at least I think so) the patches, it is not
> that important to me anymore. But still, having function names which
> precisely describe what they do would help new people understand the code.
Agree, I'm going to use more meaningful function names. Apparently the
kmalloc_nolock is still getting lockdep complain on RT kernels so I'm going to
keep this skip-preallocation logic as it is, hopefully just clearer.
Thanks,
Gabriele