Re: [PATCH v8 7/7] arm64: dts: renesas: rzg3s-smarc: Enable USB support

From: Geert Uytterhoeven

Date: Fri Oct 24 2025 - 05:27:01 EST


Hi Claudiu,

On Thu, 23 Oct 2025 at 20:41, Claudiu <claudiu.beznea@xxxxxxxxx> wrote:
> From: Claudiu Beznea <claudiu.beznea.uj@xxxxxxxxxxxxxx>
>
> Enable USB support (host, device, USB PHYs).
>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> Tested-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@xxxxxxxxxxxxxx>

Thanks for your patch!

> --- a/arch/arm64/boot/dts/renesas/rzg3s-smarc.dtsi
> +++ b/arch/arm64/boot/dts/renesas/rzg3s-smarc.dtsi

> &pinctrl {
> audio_clock_pins: audio-clock {
> pins = "AUDIO_CLK1", "AUDIO_CLK2";
> @@ -207,6 +230,27 @@ ssi3_pins: ssi3 {
> <RZG2L_PORT_PINMUX(18, 4, 8)>, /* TXD */
> <RZG2L_PORT_PINMUX(18, 5, 8)>; /* RXD */
> };
> +
> + usb0_pins: usb0 {
> + peri {
> + pinmux = <RZG2L_PORT_PINMUX(5, 0, 1)>, /* VBUS */
> + <RZG2L_PORT_PINMUX(5, 2, 1)>; /* OVC */
> + };
> +
> + otg {
> + pinmux = <RZG2L_PORT_PINMUX(5, 3, 1)>; /* OTG_ID */
> + bias-pull-up;
> + };
> + };
> +
> + usb1_pins: usb1 {
> + pinmux = <RZG2L_PORT_PINMUX(5, 4, 5)>, /* OVC */
> + <RZG2L_PORT_PINMUX(6, 0, 1)>; /* VBUS */
> + };
> +};
> +
> +&phyrst {
> + status = "okay";
> };

This node should be located before pinctrl.
No need to resend just for this.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds