Re: [PATCH net-next] net: airoha: Fix a copy and paste bug in probe()

[Lorenzo Bianconi]

> This code has a copy and paste bug where it accidentally checks "if (err)"
> instead of checking if "xsi_rsts" is NULL.  Also, as a free bonus, I
> changed the allocation from kzalloc() to  kcalloc() which is a kernel
> hardening measure to protect against integer overflows.
> 
> Fixes: 5863b4e065e2 ("net: airoha: Add airoha_eth_soc_data struct")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

Acked-by: Lorenzo Bianconi <lorenzo@xxxxxxxxxx>

> ---
>  drivers/net/ethernet/airoha/airoha_eth.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/net/ethernet/airoha/airoha_eth.c b/drivers/net/ethernet/airoha/airoha_eth.c
> index 8483ea02603e..d0ef64a87396 100644
> --- a/drivers/net/ethernet/airoha/airoha_eth.c
> +++ b/drivers/net/ethernet/airoha/airoha_eth.c
> @@ -2985,11 +2985,11 @@ static int airoha_probe(struct platform_device *pdev)
>  		return err;
>  	}
>  
> -	xsi_rsts = devm_kzalloc(eth->dev,
> -				eth->soc->num_xsi_rsts * sizeof(*xsi_rsts),
> +	xsi_rsts = devm_kcalloc(eth->dev,
> +				eth->soc->num_xsi_rsts, sizeof(*xsi_rsts),
>  				GFP_KERNEL);
> -	if (err)
> -		return err;
> +	if (!xsi_rsts)
> +		return -ENOMEM;
>  
>  	eth->xsi_rsts = xsi_rsts;
>  	for (i = 0; i < eth->soc->num_xsi_rsts; i++)
> -- 
> 2.51.0
>

Attachment: signature.asc
Description: PGP signature