Re: [PATCH] fs/9p: delete unnnecessary condition

[Christian Schoenebeck]

On Friday, October 24, 2025 1:26:00 PM CEST Dan Carpenter wrote:
> We already know that "retval" is negative, so there is no need to check
> again.  Also the statement is not indented far enough.  Delete it.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> ---

Fixes: 43c36a5
Reviewed-by: Christian Schoenebeck <linux_oss@xxxxxxxxxxxxx>

Apparently a manual revert copy paste error. The rest of the revert commit
LGTM.

/Christian

>  fs/9p/vfs_dentry.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/fs/9p/vfs_dentry.c b/fs/9p/vfs_dentry.c
> index c1acbc98465d..c5bf74d547e8 100644
> --- a/fs/9p/vfs_dentry.c
> +++ b/fs/9p/vfs_dentry.c
> @@ -109,7 +109,6 @@ static int __v9fs_lookup_revalidate(struct dentry
> *dentry, unsigned int flags) p9_debug(P9_DEBUG_VFS,
>  				"refresh inode: dentry = %pd (%p), got error %pe\n",
>  				dentry, dentry, ERR_PTR(retval));
> -		if (retval < 0)
>  			return retval;
>  		}
>  	}