Re: [PATCH] regmap: irq: Correct documentation of wake_invert flag
From: Mark Brown
Date: Fri Oct 24 2025 - 09:12:07 EST
On Fri, Oct 24, 2025 at 04:23:44PM +0800, Shawn Guo wrote:
> Per commit 9442490a0286 ("regmap: irq: Support wake IRQ mask inversion")
> the wake_invert flag is to support enable register, so cleared bits are
> wake disabled.
> - * @wake_invert: Inverted wake register: cleared bits are wake enabled.
> + * @wake_invert: Inverted wake register: cleared bits are wake disabled.
That sounds like what I'd expect for a normal polarity wake register?
I'd expect to set the bit to enable, so inverting that means that
instead we clear the bit which is what the original text says.
Attachment:
signature.asc
Description: PGP signature