Re: [PATCH net-next v7 2/5] ethtool: netlink: add ETHTOOL_MSG_MSE_GET and wire up PHY MSE access

[Oleksij Rempel]

Hi Jakub,

On Thu, Oct 23, 2025 at 06:13:43PM -0700, Jakub Kicinski wrote:
> On Mon, 20 Oct 2025 12:31:44 +0200 Oleksij Rempel wrote:
> > +      -
> > +        name: supported-caps
> > +        type: nest
> > +        nested-attributes: bitset
> > +        enum: phy-mse-capability
> 
> This is read only, does it really have to be a bitset?

It describes the capabilities of the driver/hardware. You can get always
everything... Hm... I think we continue without capabilities for now and
also remove the specific channel request.

> YNL will generate the string table automatically for user space to map
> the bits to names. And we have to do a bunch of const_ilog2() and render
> the MASK in the uAPI...

regards,
Oleksij & Marc

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |