Re: [PATCH] ASoC: spacemit: add failure check for spacemit_i2s_init_dai()
From: Dan Carpenter
Date: Fri Oct 24 2025 - 10:16:00 EST
On Fri, Oct 24, 2025 at 09:11:01PM +0800, Troy Mitchell wrote:
> Add error handling when memory allocation for dai fails in
> spacemit_i2s_init_dai() call.
>
> Signed-off-by: Troy Mitchell <troy.mitchell@xxxxxxxxxxxxxxxxxx>
> Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> ---
> Dan reported here [1].
>
> Link: https://lore.kernel.org/all/aPtiNCZ_KBezL2Dr@stanley.mountain/#t [1]
Thanks, Troy
Normally we would say this needs a Fixes tag and the Link: should be a
Closes: tag. It would be easy to make the argument that the
allocation won't fail in real life so a Fixes tag isn't appropriate. But
actually it's simpler to add the tag...
regards,
dan carpenter