Re: [PATCH v3 23/29] arm_mpam: Add mpam_msmon_read() to read monitor value

[Jonathan Cameron]

On Fri, 17 Oct 2025 18:56:39 +0000
James Morse <james.morse@xxxxxxx> wrote:

> Reading a monitor involves configuring what you want to monitor, and
> reading the value. Components made up of multiple MSC may need values
> from each MSC. MSCs may take time to configure, returning 'not ready'.
> The maximum 'not ready' time should have been provided by firmware.
> 
> Add mpam_msmon_read() to hide all this. If (one of) the MSC returns
> not ready, then wait the full timeout value before trying again.
> 
> CC: Shanker Donthineni <sdonthineni@xxxxxxxxxx>
> Signed-off-by: James Morse <james.morse@xxxxxxx>

Seems fine. Just the trivial comment below.
Reviewed-by: Jonathan Cameron <jonathan.cameron@xxxxxxxxxx>



> +static int _msmon_read(struct mpam_component *comp, struct mon_read *arg)
> +{
> +	int err,  any_err = 0;
extra space after ,

> +	struct mpam_vmsc *vmsc;