Re: [PATCH v2 2/2] add check for pointers with __free attribute initialized to NULL

From: dan.j.williams
Date: Fri Oct 24 2025 - 14:38:00 EST


Joe Perches wrote:
[..]
> > > And there are a lot of them.
> > >
> > > $ git grep -P '\b__free\b.*=\s*NULL\s*;' | wc -l
> > > 490
> >
> > That is significant. ...but you did say "almost" above. What about
> > moving this from WARN level to CHK level?
>
> I have no idea how many instances in the tree are inappropriate.
> Do you? I believe it to be a difficult analysis problem.
>
> But given the number is likely to be extremely low, I think it should
> not be added to checkpatch even as a CHK.
>
> If you can show that the reporting rate of defects is significant,
> say >10%, then OK, but I rather doubt it's that high.

Fair enough. Ally, thanks for taking a look.