Re: [PATCH v1 1/1] x86/bugs: Remove dead code which might prevent from building

From: Pawan Gupta
Date: Fri Oct 24 2025 - 18:27:33 EST


On Fri, Oct 24, 2025 at 02:59:59PM +0200, Andy Shevchenko wrote:
> Clang, in particular, is not happy about dead code:
>
> arch/x86/kernel/cpu/bugs.c:1830:20: error: unused function 'match_option' [-Werror,-Wunused-function]
> 1830 | static inline bool match_option(const char *arg, int arglen, const char *opt)
> | ^~~~~~~~~~~~
> 1 error generated.
>
> Remove a leftover from the previous cleanup.
>
> Fixes: 02ac6cc8c5a1 ("x86/bugs: Simplify SSB cmdline parsing")
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> ---
> arch/x86/kernel/cpu/bugs.c | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/arch/x86/kernel/cpu/bugs.c b/arch/x86/kernel/cpu/bugs.c
> index e08de5b0d20b..d7fa03bf51b4 100644
> --- a/arch/x86/kernel/cpu/bugs.c
> +++ b/arch/x86/kernel/cpu/bugs.c
> @@ -1827,13 +1827,6 @@ void unpriv_ebpf_notify(int new_state)
> }
> #endif
>
> -static inline bool match_option(const char *arg, int arglen, const char *opt)
> -{
> - int len = strlen(opt);
> -
> - return len == arglen && !strncmp(arg, opt, len);
> -}

Reviewed-by: Pawan Gupta <pawan.kumar.gupta@xxxxxxxxxxxxxxx>