Re: [PATCH] rust: phy: replace `MaybeUninit::zeroed().assume_init()` with `pin_init::zeroed()`
From: Miguel Ojeda
Date: Sat Oct 25 2025 - 09:00:48 EST
On Sat, Oct 25, 2025 at 2:50 PM Yizhe Sun <sunyizhe@xxxxxxxxxxxx> wrote:
>
> It is. He requested to have his patches re-sent because he didn't have time. This is my first time participating in kernel development, so please tell me if I did something wrong.
I see, thanks!
So it is this one:
https://lore.kernel.org/rust-for-linux/20250814093046.2071971-5-lossin@xxxxxxxxxx/
When submitting a patch on behalf of someone else, their Signed-off-by
tag must be kept (and then add yours too), since they are the author.
You can read about the procedure at the end of this section:
https://docs.kernel.org/process/submitting-patches.html#sign-your-work-the-developer-s-certificate-of-origin
Also, what I would normally suggest is to indicate that it is a resend
in the part outside the commit message (written right below the first
`---` line), ideally including a link to the original patch (i.e. the
first link I added here).
By the way, ideally patches also have a base commit with e.g. `git
format-patch --base`.
And no worries, it is all good, getting these details right the first
time is not trivial -- welcome! :)
If you could please resubmit it with the SoB fixed, that would be great.
Thanks!
Cheers,
Miguel