Re: [PATCH v3 1/2] nvme-pci: Print error message on failure in nvme_probe

[Wilfred Mallawa]

On Fri, 2025-10-24 at 13:05 +0200, Gerd Bayer wrote:
> Add a new error message that makes failures to probe visible in the
> kernel log, like:
> nvme 0008:00:00.0: error -ENODEV: probe failed
> 
> This highlights issues with a particular device right away instead of
> leaving users to search for missing drives.
> 
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>
> Signed-off-by: Gerd Bayer <gbayer@xxxxxxxxxxxxx>
> ---
>  drivers/nvme/host/pci.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
> index
> c916176bd9f058b49e6e6768675711df52b15765..8c624960c9f67e0cc8409023de5
> e532d6ed9b3ac 100644
> --- a/drivers/nvme/host/pci.c
> +++ b/drivers/nvme/host/pci.c
> @@ -3522,6 +3522,7 @@ static int nvme_probe(struct pci_dev *pdev,
> const struct pci_device_id *id)
>  	nvme_uninit_ctrl(&dev->ctrl);
>  out_put_ctrl:
>  	nvme_put_ctrl(&dev->ctrl);
> +	dev_err_probe(&pdev->dev, result, "probe failed\n");
>  	return result;
>  }
>  
Reviewed-by: Wilfred Mallawa <wilfred.mallawa@xxxxxxx>

Regards,
Wilfred