Re: [PATCH v2] selftests: tty: add tty_tiocsti_test to .gitignore

[Greg KH]

On Sun, Oct 26, 2025 at 12:55:46PM +0530, Gopi Krishna Menon wrote:
> Building the tty selftests generates the tty_tiocsti_test binary, which
> appears as untracked file in git. As mentioned in the kselftest
> documentation, all the generated objects must be placed inside
> .gitignore. This prevents the generated objects from accidentally
> getting staged and keeps the working tree clean.
> 
> Add the tty_tiocsti_test binary to .gitignore to avoid accidentally
> staging the build artifact and maintain a clean working tree.
> 
> Link: https://docs.kernel.org/dev-tools/kselftest.html#contributing-new-tests-details
> 
> Suggested-by: David Hunter <david.hunter.linux@xxxxxxxxx>
> Signed-off-by: Gopi Krishna Menon <krishnagopi487@xxxxxxxxx>
> ---
> Changelog:
> - Improve the commit wording and explain clearly why this change is needed.
> 
>  tools/testing/selftests/tty/.gitignore | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tools/testing/selftests/tty/.gitignore b/tools/testing/selftests/tty/.gitignore
> index fe70462a4aad..2453685d2493 100644
> --- a/tools/testing/selftests/tty/.gitignore
> +++ b/tools/testing/selftests/tty/.gitignore
> @@ -1,2 +1,3 @@
>  # SPDX-License-Identifier: GPL-2.0-only
> +tty_tiocsti_test
>  tty_tstamp_update
> -- 
> 2.43.0
> 
> 

Shouldn't this go through the tty tree that added this test?

thanks,

greg k-h