Re: [PATCH v5 05/10] dt-bindings: net: altr,socfpga-stmmac: add generic dwxgmac compatible

From: Krzysztof Kozlowski
Date: Sun Oct 26 2025 - 04:53:32 EST


On 24/10/2025 13:49, Steffen Trumtrar wrote:
> Add the more generic "snps,dwxgmac" compatible to the list of
> compatibles for the agilex5.
>
> The snps,dwmac binding explicitly uses the "snps,dwxgmac-2.10",

Hm? No, binding says only dwxgmac-2.10, DTS only dwxgmac-2.10.

> "snps,dwxgmac" combination as example; the stmmac driver only checks on

Example does not matter.

> dwmac and dwxgmac compatibles to decide what kind of gmac it is working

Huh? I clearly see snps,dwxgmac-2.10 in dwmac-generic.c

> with.
This change really lacks proper rationale.

Best regards,
Krzysztof