Re: [PATCH v7 2/4] Add SPAcc ahash support

[Pavitrakumar Managutte]

Hi Markus,
  My comments below

Warm regards,
PK

On Fri, Oct 17, 2025 at 4:36 PM Markus Elfring <Markus.Elfring@xxxxxx> wrote:
>
> >> …
> >>> +do_shash_err:
> >>> +     crypto_free_shash(hash);
> >>> +     kfree(sdesc);
> >>> +
> >>> +     return rc;
> >>> +}
> >> …
> >>
> >> * You may use an additional label for better exception handling.
> > PK: Ack, I will go with an additional label.
>
> Can scope-based resource management become applicable for more use cases?
PK: Yes, wherever applicable we will make the changes. I do see a few
use cases in the SPAcc driver code.

>
> Regards,
> Markus